Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2023

Bumps MrOctopus/download-asset-action from 1.0 to 1.1.

Release notes

Sourced from MrOctopus/download-asset-action's releases.

1.1

Updated dependencies and changed running environment to node16

Full Changelog: MrOctopus/download-asset-action@1.0...1.1

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Sep 19, 2023
@per1234 per1234 added the status: on hold Do not proceed at this time label Dec 7, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from version 2.0.0, the editorconfig-checker/action-editorconfig-checker action now acts as an installer for the editorconfig-checker tool (similar to how the actions/setup-* actions work). This means it can serve as a replacement for the MrOctopus/download-asset-action action.

The problem with the MrOctopus/download-asset-action action was fixed, but the fact that a fundamentally broken release was made in the first place (indicating there is no validation/quality control whatsoever), and then the way the fix was deployed (by moving the tag instead of making a new tag) tells me that we should avoid the use of MrOctopus/download-asset-action when possible.

See the review of the PR for the same change in the upstream template:

arduino/tooling-project-assets#396 (comment)

@per1234 per1234 self-assigned this Dec 7, 2023
@per1234 per1234 added the type: enhancement Proposed improvement label Dec 7, 2023
@per1234 per1234 removed the status: on hold Do not proceed at this time label Aug 25, 2025
@per1234
Copy link
Contributor

per1234 commented Aug 25, 2025

@dependabot rebase

Bumps [MrOctopus/download-asset-action](https://github.com/mroctopus/download-asset-action) from 1.0 to 1.1.
- [Release notes](https://github.com/mroctopus/download-asset-action/releases)
- [Commits](MrOctopus/download-asset-action@1.0...1.1)

---
updated-dependencies:
- dependency-name: MrOctopus/download-asset-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/MrOctopus/download-asset-action-1.1 branch from 4ee95e0 to 1797192 Compare August 25, 2025 20:33
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan to migrate away from this action mentioned in the previous review still stands. However, since the new version of the action is perfectly functional for the purpose, and since clearly we are not able to complete that task in a timely fashion, it is best to just go ahead with the bump.

@per1234 per1234 merged commit 659925a into main Aug 26, 2025
55 checks passed
@per1234 per1234 deleted the dependabot/github_actions/MrOctopus/download-asset-action-1.1 branch August 26, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant